[resources/processes] add user(s), state(s) attribute #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/bugfix295
branch
from
b722370
to
4c5062b
Compare
chris-rock
force-pushed
the
sr/bugfix295
branch
from
4c5062b
to
76a9782
Compare
chris-rock
force-pushed
the
sr/bugfix295
branch
from
76a9782
to
84d8a52
Compare
chris-rock
force-pushed
the
sr/bugfix295
branch
from
84d8a52
to
100652c
Compare
|
@srenatus I think we should always return an array and simplify the resource api. At the same time we may need to adapt the documentation to reflect the array return value |
srenatus
force-pushed
the
sr/bugfix295
branch
2 times, most recently
from
8bb325e
to
498d463
Compare
|
@chris-rock I agree. Updated -- hope I didn't miss any docs. |
processes('bash').user does not actually make much sense for a resource
that is a list -- different entries can belong to different users.
Analogous for processes('bash').state.
The attributes 'users' and 'states' expose the unique values
corresponding to that property of entries in the process list.
Fixes #295.
chris-rock
force-pushed
the
sr/bugfix295
branch
from
498d463
to
7a1cd66
Compare
|
@srenatus great improvement. Thank you very much! |
chris-rock
added a commit
that referenced
this pull request
Dec 8, 2015
[resources/processes] add user(s), state(s) attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processes('bash').user will be non-nil iff the process owner of each
process is the same. Analogous for processes('bash').state.
These are the only two attributes where asking for them to be unique
among multiple processes makes sense.
The attributes 'users' and 'states' expose the values corresponding to
that property of each entry in the process list.
Fixes #295.