upstart_service: fallback to config files if show-config is not available
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enabled = !config.stdout[/^\s*start on/].nil? | ||
| cmd = inspec.command("#{service_ctl} show-config #{service_name}") | ||
|
|
||
| # if initctl doesn't know `show-config`, try config file as fallback |
There was a problem hiding this comment.
I am not 100% sure, but doesn't show-config also returns a non-zero exit code, when the service is not available. Maybe its better to check for the specific version?
srenatus
force-pushed
the
sr/fix-upstart-pre-1.3
branch
from
979842e
to
66265dd
Compare
srenatus
force-pushed
the
sr/fix-upstart-pre-1.3
branch
from
51cb18c
to
b80ad94
Compare
...which are failing
before this regexp change, a service called "running" (hello integration tests) would always be "running" ;)
chris-rock
force-pushed
the
sr/fix-upstart-pre-1.3
branch
from
b80ad94
to
6887093
Compare
|
Thanks @srenatus for this improvement |
chris-rock
added a commit
that referenced
this pull request
Feb 5, 2016
upstart_service: fallback to config files if `show-config` is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417.