Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
upstart_service: fallback to config files if `show-config` is not available #419
Conversation
srenatus
added
the
Type: Bug
label
Feb 5, 2016
chef-supermarket
added
the
Signed CLA
label
Feb 5, 2016
chris-rock
reviewed
Feb 5, 2016
| - enabled = !config.stdout[/^\s*start on/].nil? | ||
| + cmd = inspec.command("#{service_ctl} show-config #{service_name}") | ||
| + | ||
| + # if initctl doesn't know `show-config`, try config file as fallback |
chris-rock
Feb 5, 2016
Contributor
I am not 100% sure, but doesn't show-config also returns a non-zero exit code, when the service is not available. Maybe its better to check for the specific version?
chef-supermarket
added
Signed CLA
labels
Feb 5, 2016
srenatus
added some commits
Feb 5, 2016
chef-supermarket
added
the
Signed CLA
label
Feb 5, 2016
|
Thanks @srenatus for this improvement |
added a commit
that referenced
this pull request
Feb 5, 2016
chris-rock
merged commit 5e1c9e2
into
master
Feb 5, 2016
chris-rock
deleted the
sr/fix-upstart-pre-1.3
branch
Feb 5, 2016
chris-rock
added this to the
0.9.12 milestone
Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
srenatus commentedFeb 5, 2016
Fixes #417.