Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instances to be provisioned with source/dest checks disabled #605

Conversation

@kapilchouhan99
Copy link
Contributor

commented Aug 20, 2019

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

  • Added disable_source_dest_check property and disable_source_dest_check method in ec2_server_create.rb file for setting sourceDestCheck attribute as false for a NAT instance to perform NAT
  • Added test cases
  • Ensured chef-style on the code changes made

Issues Resolved

Fixes: #225 MSYS-456

Check List

@vsingh-msys vsingh-msys changed the title [MSYS-456] Allow instances to be provisioned with source/dest checks disabled [WIP] Allow instances to be provisioned with source/dest checks disabled Aug 20, 2019
@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/MSYS-456_Allow_instances_to_be_provisioned_with_source/dest_checks_disabled branch from ab517b7 to ecc700a Aug 21, 2019
@kapilchouhan99 kapilchouhan99 changed the title [WIP] Allow instances to be provisioned with source/dest checks disabled [MSYS-456] Allow instances to be provisioned with source/dest checks disabled Aug 21, 2019
@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/MSYS-456_Allow_instances_to_be_provisioned_with_source/dest_checks_disabled branch 2 times, most recently from e8d6909 to ec4c52b Aug 22, 2019
@kapilchouhan99 kapilchouhan99 changed the title [MSYS-456] Allow instances to be provisioned with source/dest checks disabled [WIP] Allow instances to be provisioned with source/dest checks disabled Aug 22, 2019
…hecks disabled

Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/MSYS-456_Allow_instances_to_be_provisioned_with_source/dest_checks_disabled branch from ec4c52b to 4a34f33 Aug 27, 2019
@kapilchouhan99 kapilchouhan99 changed the title [WIP] Allow instances to be provisioned with source/dest checks disabled [MSYS-456] Allow instances to be provisioned with source/dest checks disabled Aug 27, 2019
@kapilchouhan99 kapilchouhan99 changed the title [MSYS-456] Allow instances to be provisioned with source/dest checks disabled Allow instances to be provisioned with source/dest checks disabled Aug 27, 2019
@tas50 tas50 merged commit ba79d4b into master Aug 27, 2019
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/chef-knife-ec2-master-verify Build #44 passed (2 minutes, 44 seconds)
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-ci chef-ci deleted the Kapil/MSYS-456_Allow_instances_to_be_provisioned_with_source/dest_checks_disabled branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.