Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument error for --platform option #609

Conversation

@dheerajd-msys
Copy link
Contributor

commented Sep 9, 2019

Signed-off-by: dheerajd-msys dheeraj.dubey@msystechnologies.com

Description

  • knife ec2 ami list --platform returns ERROR: ArgumentError: unexpected value at params["filters"][0][:platform]
  • Handles the error by passing appropriate content to filter array

Issues Resolved

Fixes #607

Output Post Fix

PS E:\Backup\Project\Chef_Repo\knife-ec2> bundle exec knife ec2 ami list --platform windows -c 'E:\Backup\Project\chef-starter\chef-repo\.chef\knife.rb' --owner microsoft
AMI ID        Platform  Architecture  Size  Name            Description
ami-c4169af4  windows   x86_64        35    Windows_Server
ami-c6169af6  windows   x86_64        35    Windows_Server
ami-c8169af8  windows   x86_64        30    Windows_Server
ami-c827b8f8  windows   x86_64        30    AWS             aws dc

Check List

Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
@dheerajd-msys dheerajd-msys requested review from tas50 and btm Sep 9, 2019
@Vasu1105

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

LGTM

Copy link

left a comment

LGTM!

@lamont-granquist lamont-granquist merged commit 18b1c2a into chef:master Sep 12, 2019
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/chef-knife-ec2-master-verify Build #52 passed (2 minutes, 36 seconds)
Details
expeditor/config-validation Validated your Expeditor config file
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.