KNIFE-180 - Allow :disk_config option for self managing of rackspace local disk #31

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@petecheslock
Contributor

petecheslock commented Nov 14, 2012

No description provided.

@krames

This comment has been minimized.

Show comment Hide comment
@krames

krames Jun 25, 2013

Contributor

@petecheslock Sorry about the delay on reviewing this. If you can believe it, it needs to be rebased! Any chance I could get you to do that for me? Thanks!

Contributor

krames commented Jun 25, 2013

@petecheslock Sorry about the delay on reviewing this. If you can believe it, it needs to be rebased! Any chance I could get you to do that for me? Thanks!

Allow option to pass disk_confg to fog for new server creation
Also take care of some whitespace and cleanup tags while I'm in
@petecheslock

This comment has been minimized.

Show comment Hide comment
@petecheslock

petecheslock Jun 25, 2013

Contributor

I don't have any rackspace systems to test with but about 8 months ago when we found this the kind people of Rackspace told me if we set this on larger systems the bootup time is much quicker as it won't try to make one massive root volume.

Happy to see this accepted! Let me know if you need anything else. Cleaned up some tags and whitespace while I was there as well.

Contributor

petecheslock commented Jun 25, 2013

I don't have any rackspace systems to test with but about 8 months ago when we found this the kind people of Rackspace told me if we set this on larger systems the bootup time is much quicker as it won't try to make one massive root volume.

Happy to see this accepted! Let me know if you need anything else. Cleaned up some tags and whitespace while I was there as well.

@petecheslock

This comment has been minimized.

Show comment Hide comment
@petecheslock

petecheslock Jun 25, 2013

Contributor

@krames I fixed the part of the build that was my fault - 1.8.7 will fail due to gem dep issues on travis. But this should be good - I have no way of testing this at this point, but It definitely worked 7 months ago. \o/

Contributor

petecheslock commented Jun 25, 2013

@krames I fixed the part of the build that was my fault - 1.8.7 will fail due to gem dep issues on travis. But this should be good - I have no way of testing this at this point, but It definitely worked 7 months ago. \o/

@krames

This comment has been minimized.

Show comment Hide comment
@krames

krames Jun 25, 2013

Contributor

@petecheslock I work for Rackspace and I happen to have an account. :) So I can test it for you.

I might need to get you to sign a CLA for OpsCode before we can officially merge it. I will let you know.

Here is the information on their CLA of your interested. http://wiki.opscode.com/display/chef/How+to+Contribute

Contributor

krames commented Jun 25, 2013

@petecheslock I work for Rackspace and I happen to have an account. :) So I can test it for you.

I might need to get you to sign a CLA for OpsCode before we can officially merge it. I will let you know.

Here is the information on their CLA of your interested. http://wiki.opscode.com/display/chef/How+to+Contribute

@petecheslock

This comment has been minimized.

Show comment Hide comment
@petecheslock

petecheslock Jun 25, 2013

Contributor

Already have the CLA taken care of so that should be good to go.

Contributor

petecheslock commented Jun 25, 2013

Already have the CLA taken care of so that should be good to go.

@krames

This comment has been minimized.

Show comment Hide comment
@krames

krames Jun 27, 2013

Contributor

@mattray I have tested this and it works as expected. Can you merge this?

Contributor

krames commented Jun 27, 2013

@mattray I have tested this and it works as expected. Can you merge this?

@mattray

This comment has been minimized.

Show comment Hide comment
@mattray

mattray Jun 27, 2013

Owner

Merged to master. Thanks @petecheslock and @krames!

Owner

mattray commented Jun 27, 2013

Merged to master. Thanks @petecheslock and @krames!

@mattray mattray closed this Jun 27, 2013

@petecheslock

This comment has been minimized.

Show comment Hide comment
@petecheslock

petecheslock Jun 28, 2013

Contributor

WooHoo! \o/

Contributor

petecheslock commented Jun 28, 2013

WooHoo! \o/

@krames

This comment has been minimized.

Show comment Hide comment
@krames

krames Jul 1, 2013

Contributor

@petecheslock Thanks again! And sorry about the delay!

Contributor

krames commented Jul 1, 2013

@petecheslock Thanks again! And sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment