Create os_release plugin for parsing data from /etc/os-release #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On newer Linux systems which use systemd, they should include /etc/os-release [1] which includes a lot of platform information that can be useful downstream. [1] https://www.freedesktop.org/software/systemd/man/os-release.html Signed-off-by: Lance Albertson <lance@osuosl.org>
|
This is something I've wanted us to do here for a while. Nice work. |
ramereth
added a commit
to ramereth/chef
that referenced
this pull request
Apr 7, 2021
The redhat-lsb-core isn't install as a base package which includes lsb_release so let's use os_release data first (if it's available) [1] and fall back to lsb data. [1] chef/ohai#1645 Signed-off-by: Lance Albertson <lance@osuosl.org>
ramereth
added a commit
to ramereth/chef
that referenced
this pull request
Apr 8, 2021
The redhat-lsb-core isn't install as a base package which includes lsb_release so let's use os_release data first (if it's available) [1] and fall back to lsb data. [1] chef/ohai#1645 Signed-off-by: Lance Albertson <lance@osuosl.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On newer Linux systems which use systemd, they should include
/etc/os-release[1] which includes a lot of platform information that can be useful downstream.[1] https://www.freedesktop.org/software/systemd/man/os-release.html
NOTE: If accepted, I'll make a separate PR which will update linux/platform to depend on this plugin and optimize the use of reading
/etc/os-releasein multiple places. This can also be useful in chef/chef#11296 in caselsb_releaseisn't available. I didn't want to include this in this PR in case we could back port this to 16.Signed-off-by: Lance Albertson lance@osuosl.org