OHAI-521: Google Go language plugin #206

Closed
wants to merge 6 commits into
from

Projects

None yet

5 participants

Contributor

Simple Ohai plugin for Google Go language compiler and toolchain.

https://tickets.opscode.com/browse/OHAI-521

Owner
btm commented Oct 24, 2013

Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the code review team that your contribution is ready for review.

http://wiki.opscode.com/display/chef/How+to+Contribute
http://wiki.opscode.com/display/chef/Code+Review

Contributor

Thanks for the feedback! I am an approved contributed (https://wiki.opscode.com/display/chef/Approved+Contributors) and have opened a ticket within Jira for review.

Owner
btm commented Nov 18, 2013

Please see the comments on the ticket regarding the need for a unit test.

Owner
btm commented May 6, 2014

It looks like we missed re-reviewing this. Please mark the JIRA tickets "fix provided" so that they get queued up for code review.

At the time, travis was reporting failures with the unit test that you added:

Failures:
  1) Ohai::System plugin go should get the go version
     Failure/Error: @plugin[:languages] = Mash.new
     NoMethodError:
       undefined method `[]=' for nil:NilClass
     # ./spec/unit/plugins/go_spec.rb:23:in `block (2 levels) in <top (required)>'
  2) Ohai::System plugin go should set languages[:go][:version]
     Failure/Error: @plugin[:languages] = Mash.new
     NoMethodError:
       undefined method `[]=' for nil:NilClass
     # ./spec/unit/plugins/go_spec.rb:23:in `block (2 levels) in <top (required)>'
  3) Ohai::System plugin go should not set the languages[:go] tree up if go command fails
     Failure/Error: @plugin[:languages] = Mash.new
     NoMethodError:
       undefined method `[]=' for nil:NilClass
     # ./spec/unit/plugins/go_spec.rb:23:in `block (2 levels) in <top (required)>'
Owner
sersut commented May 21, 2014

Thanks for spending time on this @christianvozar. The next step before merging this is to fix the failing specs. Let us know if you need help from our side on this.

@sersut sersut added Needs Action and removed Attack List labels Jun 25, 2014
Owner

Looks like the tests were failing because we didn't pin our rspec dependency and rspec 3 broke us. We've since fixed that, so a rebase ought to fix it. @btm is going to try rebasing the patch and re-running the tests.

@btm btm referenced this pull request Jul 14, 2014
Merged

Go plugin #366

Owner
btm commented Jul 14, 2014

Replaced by a cherry-picked branch in #366

@btm btm closed this Jul 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment