[OHAI-518] remove *.static.cloud-ips.com #215

Closed
wants to merge 1 commit into from

5 participants

@gtmanfred

Rackspace no longer sets the reverse dns for cloud servers as the spin up.

https://community.rackspace.com/general/f/34/t/623

@gtmanfred gtmanfred remove *.static.cloud-ips.com
Rackspace no longer sets the reverse dns for cloud servers as the spin
up.

https://community.rackspace.com/general/f/34/t/623
edd8e3c
@btm
Chef Software, Inc. member

@danielsdeleo - please remember to look up where we decided requires should be per best practice.

Chef Software, Inc. member

Since 'resolv' is in the standard library, we should just require it at the top.

@sersut
Chef Software, Inc. member

Thanks for the patch @gtmanfred and apologies for the delay in getting back.

Can we move the require to the top of the file and add a simple unit test so that we don't regress this functionality in the future.

Thanks for spending time and this. Let us know if you need any help with the specs.

@btm
Chef Software, Inc. member

If Rackspace is no longer automatically providing reverse DNS, and it is their address space, I presume there won't usually be a PTR record. There may be an API for setting your own reverse DNS (on creation?) but I wonder if everything will be fast enough that we would be able to get that data back via DNS immediately.

That is, I wonder if we should still be setting public_hostname?

Even so, as you can see in the Travis failure, the tests need to be updated to stub out the actual DNS call.

@squaresurf squaresurf added a commit to squaresurf/ohai that referenced this pull request Jun 23, 2014
@squaresurf squaresurf Fixes issues with Pull Request #215
This accomplishes the following:
- fixes tests for changes introduced in Pull Request #215
- moves `require "resolve"` to top of file
d8ebbc3
@squaresurf squaresurf added a commit to squaresurf/ohai that referenced this pull request Jun 24, 2014
@squaresurf squaresurf [OHAI-518] remove *.static.cloud-ips.com
Fixes issues with Pull Request #215
- fixes tests
- moves `require "resolve"` to top of file
ea92ea9
@sersut
Chef Software, Inc. member

Which of these PRs you would like to continue @squaresurf ?

#345

@squaresurf

@sersut This isn't my PR. That is why I opened the other one since I want this fixed.

@gtmanfred

I have moved on to SaltStack instead of chef. Feel free to do whatever you want with this pull request.

@gtmanfred gtmanfred closed this Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment