Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

OHAI-546: cannot print specified attributes on the command line #278

Merged
merged 2 commits into from Jan 16, 2014

Conversation

Projects
None yet
2 participants
Owner

sersut commented Jan 15, 2014

Problem:

Currently when users run ohai languages/c/version ohai doesn't return any information.

With this change, OHAI will now look for plugins that provide the first parent attribute if there are no plugins that provide any of the subattributes of the specified plugins.

@danielsdeleo / @mcquin thoughts?

sersut added some commits Jan 15, 2014

Contributor

mcquin commented Jan 16, 2014

Cool... I think we'll want to change this line to deep_find_providers_for as well, so that we can have this same behavior in regular Ohai. Either that or just use find_closest_providers_for in the Ohai app, but that's not my favorite option of the two.

Owner

sersut commented Jan 16, 2014

@mcquin I tried that option and ended up with Dependency Cycle errors because changing that line makes ohai find all the plugins under "languages" when a plugin says depends 'languages'.

I think the right way to calculate dependencies is to use the find_closest_providers_for.

sersut pushed a commit that referenced this pull request Jan 16, 2014

Merge pull request #278 from opscode/OHAI-546
OHAI-546: cannot print specified attributes on the command line

@sersut sersut merged commit fc72e66 into master Jan 16, 2014

1 check passed

default The Travis CI build passed
Details

@danielsdeleo danielsdeleo deleted the OHAI-546 branch Jan 16, 2014

@lamont-granquist lamont-granquist locked and limited conversation to collaborators Nov 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.