OHAI-525: reverting part of OHAI-525 #280

Merged
merged 2 commits into from Jan 16, 2014

Projects

None yet

2 participants

Contributor

dmidecode isn't necessarily installed by default (fedora 20), while
the existing /proc/modules detection works fine. i don't see why we
only need one mechanism, so try both and use which one works.

@lamont-granquist lamont-granquist OHAI-525: reverting part of OHAI-525
dmidecode isn't necessarily installed by default (fedora 20), while
the existing /proc/modules detection works fine.  i don't see why we
only need one mechanism, so try both and use which one works.
f5013a3
Owner

Any hope of having tests for this? It'd be nice if you had a test that said "Virtualization plugin when dmidecode is not available detects vbox using kernel modules"

Owner

LGTM

@lamont-granquist lamont-granquist merged commit f53bda7 into master Jan 16, 2014

1 check passed

default The Travis CI build passed
Details
@lamont-granquist lamont-granquist deleted the lcg/revert-OHAI-525-part branch Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment