If can't find an expected piece of metadata, log and continue #283

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@johnke

johnke commented Jan 23, 2014

On certain instance types (e.g. hi.4xlarge), AWS returns 404 for certain pieces of metadata (e.g. on a hi.4xlarge, metrics/vhostmd returns 404). A half-completed ec2 section in ohai is still more helpful than an empty ec2 section, so log the error and continue, rather than raising an exception.

See also: https://tickets.opscode.com/browse/OHAI-541

@miketheman

This comment has been minimized.

Show comment Hide comment
@miketheman

miketheman May 9, 2014

Member

I support this approach - some data is better than none.

Member

miketheman commented May 9, 2014

I support this approach - some data is better than none.

@btm

This comment has been minimized.

Show comment Hide comment
@btm

btm May 12, 2014

Member

@miketheman is working on a fix over at #332 that deals with returning a sane body and provides a unit test.

Member

btm commented May 12, 2014

@miketheman is working on a fix over at #332 that deals with returning a sane body and provides a unit test.

@btm btm closed this May 12, 2014

@lamont-granquist lamont-granquist locked and limited conversation to collaborators Nov 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.