Attribute for depsolver_timeout not used anywhere #79

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pburkholder
Contributor

The chef-server attributes includes despsolver_timeout but that value wasn't applied anywhere. Changed that value to match the
hard-coded value, 2000, at

https://github.com/opscode/chef_objects/blob/master/src/chef_depsolver.erl#L46

and updated erchef.config to use that value per

https://github.com/opscode/chef_objects/blob/master/src/chef_depsolver.erl#L127

@pburkholder pburkholder changed the title from The chef-server attributes includes `despsolver_timeout` but that to Attribute for depsolver_timeout not used anywhere Jul 23, 2014
@mmzyk
Member
mmzyk commented Aug 1, 2014

Hey @pburkholder - thanks for this, it's been merged into master and will start showing up in the nightlies. I didn't merge your branch directly, because after some internal discussion we decided the timeout should be 5000 by default, so I made a change to keep it at that. 5000 is the default in enterprise chef and we want to keep the two chef's in sync, even if buried in the code the hardcoded default is 2000. You were right to go with the 2000 value when creating this PR though.

You can see that your change was merged here: 9dd7d35

@mmzyk mmzyk closed this Aug 1, 2014
@pburkholder
Contributor

Thanks. I'm agnostic to what the value should be, just that it gets used. Cheers, Peter

@mmzyk
Member
mmzyk commented Aug 1, 2014

@pburkholder I figured the actual value didn't matter much to you, but I wanted to give a full explanation for why it was changed from what you submitted. Thanks for the patch, it's appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment