Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Ruby to 2.6.5 #1852

Merged
merged 2 commits into from Mar 4, 2020
Merged

upgrade Ruby to 2.6.5 #1852

merged 2 commits into from Mar 4, 2020

Conversation

@robbkidd
Copy link
Member

robbkidd commented Mar 4, 2020

Description

A new version of chef-zero (a dependency of chef) bumped to require Ruby 2.6. That requirement has inspired a version bump!

Changes to src/supermarket/

  • Bumped several gems in supermarket and the fieri engine to quiet deprecation notices.

Changes to omnibus/

The version of rubygems and bundler must be consistent with the version included in the embedded Ruby install or we'll get double-bundler problems.

  • versions of ruby, rubygems, and bundler overridden in the supermarket software definition
  • BUNDLED WITH updated in the Gemfile.locks to match the version of bundler embedded in the install
  • updated the omnibus and omnibus-software gems to have access to the new versions of components
  • berkshelf installed as a gem instead of as an omnibus software dependency because it installs from git with bundler and its Gemfile.lock is an older version of bundler that does not match the one this change uses
  • update the embedded chef-client to latest 14 - the ctl-reconfigure command provided by omnibus-ctl uses the --chef-license switch. Need to update to a version of 14 with that switch backported as a no-op or else supermarket-ctl reconfigure would fail with a message about an invalid option.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.
@robbkidd robbkidd requested a review from chef/jex-team as a code owner Mar 4, 2020
robbkidd added 2 commits Mar 3, 2020
Signed-off-by: Robb Kidd <rkidd@chef.io>
The version of rubygems and bundler must be consistent witht the version
included in the embedded Ruby install or we'll get double-bundler
problems.

* versions overridden in the supermarket software definition
* BUNDLED WITH updated in the Gemfile.locks
* updated the omnibus and omnibus-software gems to have access to the
  new versions of components
* berkshelf installed as a gem instead of as an omnibus software
  dependency because it installs from git with bundler and its
  Gemfile.lock is an older version of bundler that does not match
  the one this change uses
* update the embedded chef-client to latest 14 - the ctl-reconfigure
  command provided by omnibus-ctl uses the --chef-license switch.
  Need to update to a version of 14 with that switch backported as
  a no-op or else supermarket-ctl reconfigure would fail with a message
  about an invalid option.

Signed-off-by: Robb Kidd <rkidd@chef.io>
@robbkidd robbkidd force-pushed the upgrade-ruby-n-such branch from a6060fa to e57a761 Mar 4, 2020
@robbkidd robbkidd merged commit 3ee21cb into master Mar 4, 2020
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the upgrade-ruby-n-such branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.