New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate cookbook dependencies #461

Merged
merged 2 commits into from Jun 17, 2014

Conversation

Projects
None yet
2 participants
@bcobb
Contributor

bcobb commented Jun 16, 2014

馃嵈

This should fix #442. It adds two migrations:

  1. Removes duplicate cookbook dependency records
  2. Adds an index to prevent duplicate dependency records

In the future we may want to give CookbookDependency the same treatment as SupportedPlatform.

bcobb added some commits Jun 16, 2014

Remove duplicate Cookbook Dependency records
The migration looks a little different than a usual migration. This
approach ought to allow us to remove the data migration implementation
class -- Supermarket::Migration::RemoveDuplicateCookbookDependencies --
from the repo without affecting `rake db:migrate` which as of now Travis
still runs every time it builds the project.

@bcobb bcobb added the Signed CLA label Jun 16, 2014

@brettchalupa

This comment has been minimized.

Contributor

brettchalupa commented Jun 16, 2014

This makes sense and looks good to me.

bcobb added a commit that referenced this pull request Jun 17, 2014

@bcobb bcobb merged commit 5cb047f into master Jun 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bcobb bcobb deleted the deduplicate-cookbook-dependencies branch Jun 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment