New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprocess imported archives #580

Merged
merged 2 commits into from Jul 10, 2014

Conversation

Projects
None yet
2 participants
@bcobb
Contributor

bcobb commented Jul 10, 2014

馃嵈

This ought to fix #579. The idea is that @cwebberOps will run rake supermarket:rebuild_cookbook_version_dependencies on a production node, which will queue jobs for the new worker.

The job itself pulls down a CookbookVersion's tarball, identifies any dependencies with version constraints which don't match the metadata-specified constraint exactly, and updates those dependencies accordingly. The two major discrepancies this fixes are:

  1. OPERATOR MAJOR.MINOR imported as OPERATOR MAJOR.MINOR.0
  2. MAJOR.MINOR.PATCH imported as = MAJOR.MINOR.PATCH

The worker's spec has concrete examples.

I'd like to put together one revertible commit before merging, but will keep the smaller commits around until this has the 馃憤

@bcobb bcobb added the Signed CLA label Jul 10, 2014

@brettchalupa

This comment has been minimized.

Contributor

brettchalupa commented Jul 10, 2014

rubocop here letting you know to: "Use next to skip iteration"

robocop

@bcobb bcobb added Signed CLA and removed Signed CLA labels Jul 10, 2014

@bcobb

This comment has been minimized.

Contributor

bcobb commented Jul 10, 2014

Pushed a rubocop fix.

@brettchalupa

This comment has been minimized.

Contributor

brettchalupa commented Jul 10, 2014

馃憤 looked over this and it LGTM

bcobb added some commits Jul 10, 2014

Add task to rebuild CookbookVersion dependencies
The data migration erroneously migrated version constraints of the form
`OPERATOR MAJOR.MINOR` as `OPERATOR MAJOR.MINOR.0`. To fix this, we add
a worker which corrects that mistake for a single CookbookVersion, and a
rake task which can seed it with jobs.

@bcobb bcobb added Signed CLA and removed Signed CLA labels Jul 10, 2014

@bcobb

This comment has been minimized.

Contributor

bcobb commented Jul 10, 2014

馃啋 Just pushed the squashed version. 48372ca can be reverted after the issue is completely resolved.

bcobb added a commit that referenced this pull request Jul 10, 2014

@bcobb bcobb merged commit 5039df9 into master Jul 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bcobb bcobb deleted the reprocess-imported-archives branch Jul 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment