Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, use Syscall instead of Syscall6 #192

Merged
merged 5 commits into from May 9, 2022

Conversation

dmitryk-dk
Copy link
Contributor

@dmitryk-dk dmitryk-dk commented May 8, 2022

This PR fixes error when you tries to build app with GOOS=solaris env

@dmitryk-dk dmitryk-dk changed the title Update dependencies, use term instead of Syscall Update dependencies, use Syscall instead of Syscall6 May 8, 2022
@dmitryk-dk
Copy link
Contributor Author

dmitryk-dk commented May 9, 2022

Hi @cheggaaa ! Can you please take a look at this PR. The main problem is when you are trying to build some ctl app with your library for solaris OS it crashes with the following error

github.com/cheggaaa/pb/v3/termutil.lockEcho: relocation target syscall.Syscall6 not defined
github.com/cheggaaa/pb/v3/termutil.unlockEcho: relocation target syscall.Syscall6 not defined
make[1]: *** [Makefile:263: app-local-pure] Error 2

@cheggaaa
Copy link
Owner

cheggaaa commented May 9, 2022

Hi! Thank you for PR
I think we need to keep old build rules too (// +build) Go authors recommended having both forms (https://tip.golang.org/doc/go1.17#go-command)
Is it necessary to change the go version for switching to Syscall? Because I think it's good to keep the older version for compatibility reasons.

@dmitryk-dk
Copy link
Contributor Author

dmitryk-dk commented May 9, 2022

Hi @cheggaaa ! I have rollbacked old build rules, please check.

@cheggaaa cheggaaa merged commit 56b7944 into cheggaaa:v3-pooling May 9, 2022
@cheggaaa
Copy link
Owner

cheggaaa commented May 9, 2022

Thanks! Merged into v3-pooling
Also this or next week I will finally review and test v3-pooling

@dmitryk-dk
Copy link
Contributor Author

dmitryk-dk commented May 9, 2022

@cheggaaa it would be great)!

@dmitryk-dk
Copy link
Contributor Author

dmitryk-dk commented May 9, 2022

Also i have tested it a little bit)

@valyala
Copy link

valyala commented Jun 30, 2022

@cheggaaa, is there an ETA for merging v3-pooling branch into main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants