Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support to 64 bit offset file #12

Merged
merged 3 commits into from Jun 12, 2017
Merged

Conversation

Manohar-94
Copy link
Contributor

Added support to 64 bit offset files which are not larger than 4GB (0 in the first 32 bits of offset).
Also added a test case to read a 64 bit file.

@codecov-io
Copy link

codecov-io commented Jun 11, 2017

Codecov Report

Merging #12 into master will increase coverage by 1.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   91.66%   93.04%   +1.37%     
==========================================
  Files           5        5              
  Lines         228      230       +2     
  Branches       39       40       +1     
==========================================
+ Hits          209      214       +5     
+ Misses         19       16       -3
Impacted Files Coverage Δ
src/header.js 95% <100%> (+2.89%) ⬆️
src/index.js 100% <100%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9372712...2d4aff2. Read the comment docs.

@maasencioh maasencioh merged commit 32d5e2a into cheminfo:master Jun 12, 2017
@maasencioh
Copy link
Member

Hello @Manohar-94, thank you for the contribution, I removed some unused files but everything looks perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants