Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated 'create-react-class' dependencies in tests to ES6 classes #462

Merged
merged 3 commits into from Apr 25, 2017

Conversation

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Apr 25, 2017

Fixes #461

CC: @nkbt

@nkbt

This comment has been minimized.

Copy link
Collaborator

nkbt commented Apr 25, 2017

Awesome!

@MichaelDeBoey

This comment has been minimized.

Copy link
Contributor Author

MichaelDeBoey commented Apr 25, 2017

@nkbt just have to fix the linting errors now :P

@MichaelDeBoey

This comment has been minimized.

Copy link
Contributor Author

MichaelDeBoey commented Apr 25, 2017

@nkbt Fixed :-)

@@ -11,7 +11,7 @@
"build/react-motion.map"
],
"dependencies": {
"react": ">=0.13.2 || ^0.14 || ^15.0.0"
"react": "^0.14.9 || ^15.3.0"

This comment has been minimized.

Copy link
@nkbt

nkbt Apr 25, 2017

Collaborator

oh, thanks for that

This comment has been minimized.

Copy link
@MichaelDeBoey

MichaelDeBoey Apr 25, 2017

Author Contributor

You're welcome 😃

@@ -1,5 +1,5 @@
/* eslint-disable class-methods-use-this */

This comment has been minimized.

Copy link
@nkbt

nkbt Apr 25, 2017

Collaborator

"fixed" =)

Apparently we can make those methods static according to http://eslint.org/docs/rules/class-methods-use-this

But that is OK for the moment. I'd rather get tests working now.

This comment has been minimized.

Copy link
@MichaelDeBoey

MichaelDeBoey Apr 25, 2017

Author Contributor

Yes indeed, but render isn't supposed to be static so that's why I did it like this

@nkbt
nkbt approved these changes Apr 25, 2017
@nkbt nkbt merged commit e8dace0 into chenglou:master Apr 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MichaelDeBoey MichaelDeBoey deleted the MichaelDeBoey:ES6 branch Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.