Comments #9

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
@ivmos

ivmos commented Oct 11, 2016

Hi

Which plans do you have in order to support descriptions autogeneration?

I'd like to show you the branch I currently use, probably hacky to be merged but It has done the job I needed.

I fill the descriptions based on txt files generated on the target project. I generate those files in the web service projects with maven-javadoc-plugin. See doclet class example in http://stackoverflow.com/questions/8504013/how-to-read-javadoc-comments-by-reflection

There are also some changes I've needed like styles changes so that space is better used, ordering methods alphabetically so that doc does not change every time wsdl is regenerated and removing required field as for me it's useless unless it can be autogenerated.

BTW congrats for the tool :)

@chenjianjx

This comment has been minimized.

Show comment
Hide comment
@chenjianjx

chenjianjx Oct 11, 2016

Owner

Thank you for your contribution.

Can you show me an example WSDL and the html result output by your code?

Owner

chenjianjx commented Oct 11, 2016

Thank you for your contribution.

Can you show me an example WSDL and the html result output by your code?

@ivmos

This comment has been minimized.

Show comment
Hide comment
@ivmos

ivmos Oct 11, 2016

Sure, I'll prepare a sample project. Next week though as I've just started vacations.

ivmos commented Oct 11, 2016

Sure, I'll prepare a sample project. Next week though as I've just started vacations.

@ivmos

This comment has been minimized.

Show comment
Hide comment
@chenjianjx

This comment has been minimized.

Show comment
Hide comment
@chenjianjx

chenjianjx Oct 21, 2016

Owner

The comments are not inside your sample WSDL, man. They should be inside the WSDL, so people can get things done by inputting a single WSDL file.

Owner

chenjianjx commented Oct 21, 2016

The comments are not inside your sample WSDL, man. They should be inside the WSDL, so people can get things done by inputting a single WSDL file.

@ivmos

This comment has been minimized.

Show comment
Hide comment
@ivmos

ivmos Oct 21, 2016

Let me explain my use case. I don't create the wsdl manually, I use jax-ws. That's why I look for comments in javadoc. Afaik, jax-ws doesn't support comments.

I would understand this branch not being generic enough. If so I might fork a wsdl2html_jaxws, just for the shake of having this feature merged somewhere. I consider it ok for my use case, others might too until a better solution is available. Thanks again :)

ivmos commented Oct 21, 2016

Let me explain my use case. I don't create the wsdl manually, I use jax-ws. That's why I look for comments in javadoc. Afaik, jax-ws doesn't support comments.

I would understand this branch not being generic enough. If so I might fork a wsdl2html_jaxws, just for the shake of having this feature merged somewhere. I consider it ok for my use case, others might too until a better solution is available. Thanks again :)

@chenjianjx chenjianjx closed this Oct 21, 2016

@ivmos ivmos referenced this pull request in ivmos/wsdl2html_ivmos Oct 22, 2016

Merged

Merge Comments branch #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment