Weird crash in production

[PomepuyN]

I don't really know where the issue may come from.
I'm getting this kind of crashes in my app:

android.database.sqlite.SQLiteException: no such column: SHADOWMONITOR (code 1): , while compiling: UPDATE USER SET SHADOWMONITOR=?,SHADOWKLASS=?,TOTAL=?,PAGE=?,CURRENT=?,USER_ID=?,USER_NAME=? WHERE ID = ?
       at android.database.sqlite.SQLiteConnection.nativePrepareStatement(SQLiteConnection.java)
       at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:889)
       at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:500)
       at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:588)
       at android.database.sqlite.SQLiteProgram.<init>(SQLiteProgram.java:58)
       at android.database.sqlite.SQLiteStatement.<init>(SQLiteStatement.java:31)
       at android.database.sqlite.SQLiteDatabase.updateWithOnConflict(SQLiteDatabase.java:1572)
       at android.database.sqlite.SQLiteDatabase.update(SQLiteDatabase.java:1520)
       at com.orm.SugarRecord.save()
       at com.orm.SugarRecord.save()
       at com.npi.muzeiflickr.db.User.incrementCurrent(User.java:76)
       at com.npi.muzeiflickr.api.FlickrSource.onTryUpdate(FlickrSource.java:142)
       at com.google.android.apps.muzei.api.RemoteMuzeiArtSource.onUpdate(RemoteMuzeiArtSource.java:105)
       at com.google.android.apps.muzei.api.MuzeiArtSource.processHandleCommand(MuzeiArtSource.java:639)
       at com.google.android.apps.muzei.api.MuzeiArtSource.onHandleIntent(MuzeiArtSource.java:545)
       at com.npi.muzeiflickr.api.FlickrSource.onHandleIntent(FlickrSource.java:727)
       at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:136)
       at android.os.HandlerThread.run(HandlerThread.java:61)

I tried to search for "SHADOWMONITOR" in both my app the library. I ended up by searching it on Google and I cannot find a reference to this.

Here is the line where the issue comes from: https://github.com/PomepuyN/muzei-flickr/blob/Development/MuzeiFlickr/src/main/java/com/npi/muzeiflickr/db/User.java?source=c#L76

Is the "User" word allowed for DB Tables? If yes, do you have an idea what happens here?

[satyan]

were you able to determine the cause? I don't see any reason for this error to come.. Is this occasional or regular error?

[PomepuyN]

Unfortunately, it's not occasional. It's the first source of crashes for my app (21 occurrences today).
Here are the full information about it: http://crashes.to/s/84527a7975b
I made more search about it but I was unable to find where it may come from.

What I don't understand is why there is a mix of valid columns and invalid one.

SHADOWMONITOR (code 1): , while compiling: UPDATE F_GROUP SET SHADOWMONITOR=?,SHADOWKLASS=?,TOTAL=?,GROUP_ID=?,NAME=?,PAGE=?,CURRENT=? WHERE ID = ?

My entity:

public class FGroup extends SugarRecord<FGroup> implements RequestData {

    int total;
    int current;
    String name;
    public String groupId;
    public int page;

    public FGroup() {
        super();
    }

    public FGroup(Context context, String groupId, String name, int page, int current, int total) {
        super();
        this.name = name;
        this.groupId = groupId;
        this.current = current;
        this.total = total;
    }
}

It seems to only occur on "UPDATE" commands but on different entities.

[gaddas]

It's because the users had ART activated (read more http://source.android.com/devices/tech/dalvik/art.html ). It implements the base type Object with 2 extra fields:

public class Object {
    private transient Class<?> shadow$_klass_;
    private transient int shadow$_monitor_;

I made a pull request, but have missed the 2nd field initially.

[satyan]

ah.. that explains.. I did go through your pull request, but couldn't test it coz of lack of ART based device.

We could skip the transient fields.. that should be good enough. right?

[satyan]

@PomepuyN @gaddas Would you be able to test it out.. in SugarRecord.java line no: 360

 for (Field field : typeFields) {
            if (!field.isAnnotationPresent(Ignore.class) && !Modifier.isStatic(field.getModifiers())&& !Modifier.isTransient(field.getModifiers())) {
                toStore.add(field);
            }
        }

[satyan]

@PomepuyN you can try out the latest 1.3_beta jar.. it has the above change.

[gaddas]

The example application is working - I tested without the change (got same error) and without (the error was gone).

[satyan]

Cool.. Thanks

[PomepuyN]

Great!
Thanks a lot @gaddas
@satyan I will include the new jar and let you know if it solved my issue. I think I will be able to release it tomorrow.

[PomepuyN]

Ok.
After two days in production, there are no more crashes.
Once again thanks to @gaddas and @satyan 👍

[satyan]

closing this.. as it looks fixed.

[Giorgi]

Perhaps it makes sense not to get fields on base class if the base class is Object so that we avoid crashes in future if Google adds other fields?