Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests don't pass #157

Closed
yarax opened this issue Jan 10, 2017 · 9 comments · Fixed by #162
Closed

Pull requests don't pass #157

yarax opened this issue Jan 10, 2017 · 9 comments · Fixed by #162

Comments

@yarax
Copy link
Contributor

yarax commented Jan 10, 2017

Guys, seems like new awesome bot doesn't pass new pull requests, because already existing links in README:
#156
https://travis-ci.org/chentsulin/awesome-graphql/builds/190590030
So as you see tests are failed because of

Issues :-(
> Links 
  1. [L124] 404 https://github.com/rmosolgo/graphql-relay-ruby  
  2. [L293] 301 https://github.com/kriasoft/graphql-starter-kit  → https://github.com/kriasoft/nodejs-api-starter 

not because of swagger2graphql itself

@pluma
Copy link
Contributor

pluma commented Jan 24, 2017

I've addressed the most recent batch of errors in #164

I guess #162 is a more permanent solution to this problem but would require running awesome bot manually every now and then to catch outdated URLs.

@yarax
Copy link
Contributor Author

yarax commented Jan 24, 2017

Can I help here with something?

@pluma
Copy link
Contributor

pluma commented Jan 24, 2017

FWIW the contributor badge just means I've had a PR merged. I'm not a maintainer.

That said, it's probably past the maintainer's bedtime right now: https://time.is/Taipei

So I guess just wait a day or so ;)

@pluma
Copy link
Contributor

pluma commented Jan 26, 2017

@yarax FYI #164 was merged and master is now green again (until the next URI falls out of date).

@yarax
Copy link
Contributor Author

yarax commented Jan 30, 2017

Tried again. Still fails because of other links :( #167

@m1guelpf
Copy link
Contributor

I think you should really consider #162

@yarax
Copy link
Contributor Author

yarax commented Jan 30, 2017

@m1guelpf can you please explain what should I consider?
162 PR is about checking only changes.
I'm suggesting my changes and getting back error in another part of file:

Issues :-(
> Links 
  1. [L365]  http://swapi.graphene-python.org Connection reset by peer 

@pluma
Copy link
Contributor

pluma commented Jan 31, 2017

Awesome!

@stubailo Any chance of getting green PRs merged now?

@yarax
Copy link
Contributor Author

yarax commented Jan 31, 2017

Thank you @stubailo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants