Permalink
Browse files

I would like to dedicate this patch to Mehmet Ali Shahin, who found t…

…his issue about 1.5 year ago, and actively participated to figure out this bug. The actual problem is that cherokee_handler_file_free does free all things around cherokee_handler_file but not the initial struct to store it. The function cherokee_handler_free calls the previous and frees the pointer. As you can see this happened in another location as well.
  • Loading branch information...
skinkie committed Jan 18, 2013
1 parent b4726f0 commit 4294ceac85256831f0828e4c75d070fb7d231907
Showing with 2 additions and 2 deletions.
  1. +1 −1 cherokee/handler_render_rrd.c
  2. +1 −1 cherokee/handler_streaming.c
@@ -556,7 +556,7 @@ handler_free (cherokee_handler_render_rrd_t *hdl)
cherokee_buffer_mrproper (&hdl->rrd_error);
if (hdl->file_hdl != NULL) {
- cherokee_handler_file_free (hdl->file_hdl);
+ cherokee_handler_free ((void *) hdl->file_hdl);
}
return ret_ok;
@@ -107,7 +107,7 @@ ret_t
cherokee_handler_streaming_free (cherokee_handler_streaming_t *hdl)
{
if (hdl->handler_file != NULL) {
- cherokee_handler_file_free (hdl->handler_file);
+ cherokee_handler_free ((void *) hdl->handler_file);
}
if (hdl->avformat != NULL) {

0 comments on commit 4294cea

Please sign in to comment.