Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Encoders compression level #753

Closed
Borkason opened this Issue Mar 24, 2013 · 9 comments

Comments

Projects
None yet
1 participant
Member

Borkason commented Mar 24, 2013

Original author: skar...@gmail.com (November 26, 2010 01:01:36)

Add the possibility to change the compression level of encoders.

Original issue: http://code.google.com/p/cherokee/issues/detail?id=1054

Member

Borkason commented Mar 24, 2013

From alobbs on November 26, 2010 07:11:02
Even though it's easily implementable, I do not think it is a useful option. AFAIK, the faster compression is the one with a higher ""value"": (compression ration / CPU required).

Member

Borkason commented Mar 24, 2013

From skar...@gmail.com on November 26, 2010 08:14:29
I've read (listen in a podcast actually) that meneame.net, a very with high loaded site, got a better relation cpu usage / network use perfomance tunning this parameter to a value of 4.

Member

Borkason commented Mar 24, 2013

From alobbs on November 26, 2010 20:16:52
What started being a tiny patch that was supposed to take me 5 mins to get done and dusted, ended up being a 24K patch that reimplemented how encoders are configured and instanced by the core of the server.

Basically, this patch makes cherokee_encoder_t objects to become as important as cherokee_handler_t objects. Until now they were treated as kind of second class citizens. (They did not even have a configuration section).

I'd really appreciate if you guys could give me a hand to ensure this patch works as expected. So far I have done a couple of tests by hand and everything seems to work fine (the QA bench passes as well) although more testing is required before applying this sort of intrusive patch.

Thanks!!

Member

Borkason commented Mar 24, 2013

From alobbs on November 29, 2010 16:56:43
http://svn.cherokee-project.com/changeset/5845

Member

Borkason commented Mar 24, 2013

From skar...@gmail.com on November 30, 2010 08:53:50
After some tests all looks fine. :-)

BTW, the admin side is not done yet.

Member

Borkason commented Mar 24, 2013

From alobbs on November 30, 2010 09:02:08
I wanted to figure a way to implement it that did not involve to raise the complexity of part of the interface. Do you have some idea?

Member

Borkason commented Mar 24, 2013

From alobbs on December 05, 2010 21:04:53
http://svn.cherokee-project.com/changeset/5878 implemented the Cherokee-admin side of things.

Member

Borkason commented Mar 24, 2013

From alobbs on December 05, 2010 21:53:51
http://svn.cherokee-project.com/changeset/5879 implemented the last missing bits.

Member

Borkason commented Mar 24, 2013

From skar...@gmail.com on December 09, 2010 00:31:34
It's OK for me... Thanks! ;-)

@Borkason Borkason closed this Mar 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment