Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ssl: When no SNI is present, use the _server_ IP as 'servername' #1032
Previously this used the client IP ... which is really annoying and
Matching on the server IP is already possible using the v_target_ip
Signed-off-by: Sylvain Munaut tnt@246tNt.com
The current code does :
cherokee_socket_ntop (&conn->socket, tmp.buf, tmp.size);
But never sets tmp.len properly, so the end result is that this 'server name' will never match anything when trying to match it in vrule_rehost.c (because the pcre match call is limited to the .len of the cherokee_buffer).
So all in all, nobody ever could have successfully used the previous code.