Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SHA{1,512}: Rename structs and functions #1109

Merged
merged 1 commit into from Jan 31, 2014

Conversation

Projects
None yet
2 participants
Contributor

kinnison commented Jan 31, 2014

By ensuring that the SHA1 and SHA512 code in Cherokee does
not stomp on symbols provided by libssl, we prevent a problem
where the relative sizes of the structs means that Cherokee's
SHA512 operations break SSL handshakes.

Signed-Off-By: Daniel Silverstone dsilvers@digital-scurf.org

@kinnison kinnison SHA{1,512}: Rename structs and functions
	By ensuring that the SHA1 and SHA512 code in Cherokee does
	not stomp on symbols provided by libssl, we prevent a problem
	where the relative sizes of the structs means that Cherokee's
	SHA512 operations break SSL handshakes.

Signed-Off-By: Daniel Silverstone <dsilvers@digital-scurf.org>
f1adec0
Member

skinkie commented Jan 31, 2014

I think this is good to apply. A similar problem is with the 'template' code in Cherokee where template is a registered keyword in a C++ compiler. So my guess is that we should change that as well.

@skinkie skinkie added a commit that referenced this pull request Jan 31, 2014

@skinkie skinkie Merge pull request #1109 from kinnison/kinnison/rename-sha-functions
SHA{1,512}: Rename structs and functions
66d190e

@skinkie skinkie merged commit 66d190e into cherokee:master Jan 31, 2014

@kinnison kinnison deleted the kinnison:kinnison/rename-sha-functions branch Feb 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment