Skip to content
This repository

fastcgi + flup breaks when post request has no content #12

Closed
wants to merge 1 commit into from

2 participants

Samuel Cormier-Iijima Alvaro Lopez Ortega
Samuel Cormier-Iijima

Fix compatibility issue #11 when an empty POST request is sent to a flup-powered FastCGI backend

Alvaro Lopez Ortega
Owner

The patch is now merged in the "dev" branch.
Thank you very much -- Good stuff!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 09, 2011
Samuel Cormier-Iijima sciyoshi Fix compatibility issue #11 when an empty POST request is sent to a f…
…lup-powered FastCGI backend
8657b7e
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  cherokee/handler_fcgi.c
2  cherokee/handler_fcgi.c
@@ -516,7 +516,7 @@ build_header (cherokee_handler_fcgi_t *hdl, cherokee_buffer_t *buffer)
516 516
517 517 /* No POST?
518 518 */
519   - if ((! http_method_with_input (conn->header.method)) || (! conn->post.has_info)) {
  519 + if ((! http_method_with_input (conn->header.method)) || (! conn->post.has_info) || (! conn->post.len)) {
520 520 TRACE (ENTRIES",post", "Post: %s\n", "has no post");
521 521 add_empty_packet (hdl, FCGI_STDIN);
522 522 }

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.