Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

av_close_input is not working in cherokee_handler_streaming_free #57

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

mehmetali commented Jan 17, 2013

I think, av_close_input isn't working in cherokee_handler_streaming_free function and cause memory leak.

Update cherokee/handler_streaming.c
I think, av_close_input isn't working in cherokee_handler_streaming_free function and cause memory leak.
Member

skinkie commented Jan 17, 2013

My main problem with this is that when I add TRACE statements I get the following output:

handler_streaming.c:0311 ( open_media_file): open_media_file /home/skinkie/base/var/www/test.mp3
[mp3 @ 0xb1505a60] max_analyze_duration 5000000 reached at 5015510
[mp3 @ 0xb1505a60] Estimating duration from bitrate, this may be inaccurate
handler_streaming.c:0375 ( set_auto_rate): Duration: 8058 seconds
handler_streaming.c:0376 ( set_auto_rate): Rate: 64000 bps (8000 bytes/s)
handler_streaming.c:0301 ( set_rate): Limiting rate (initial boost): 44000 bytes, until=44000
handler_streaming.c:0531 (cherokee_handler_streaming_step): Limiting rate: 8800 bytes/s
handler_streaming.c:0114 (cherokee_handler_streaming_free): close_file (free) /home/skinkie/base/var/www/test.mp3

The last close only after the streaming is done. While I do agree it is not required to wait with closing ffmpeg until the file is finished, I am worried that when ret_error is returned somewhere in the process of setting it up we might miss a spot (this has to be validated) and leak as well.

With the instructions you mailed me I am going to test cherokee.

Member

skinkie commented Jan 18, 2013

Did it in a different way, thanks anyway :)

@skinkie skinkie closed this Jan 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment