New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg shouldn't supply 'license' #154

Closed
jaraco opened this Issue Dec 29, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@jaraco
Copy link
Member

jaraco commented Dec 29, 2018

The license parameter to setup should be removed. The docs for that parameter indicate that the parameter is only intended when the license can't be specified by the trove classifiers.

@webknjaz

This comment has been minimized.

Copy link
Member

webknjaz commented Dec 29, 2018

@serhii73 do you want to give it a try?

@webknjaz webknjaz changed the title setup.py shouldn't supply 'license' setup.cfg shouldn't supply 'license' Dec 29, 2018

@serhii73

This comment has been minimized.

Copy link
Contributor

serhii73 commented Dec 29, 2018

@webknjaz Yes. It will be brilliant for me.
I try to send PR on Monday.
I not sure I fully understand the task.
https://github.com/cherrypy/cheroot/blob/master/setup.cfg - I need work only with this file?
Just to remove the line license_file = LICENSE.md?
Did I confuse it?

@jaraco

This comment has been minimized.

Copy link
Member

jaraco commented Dec 29, 2018

@serhii73 Glad for the extra help. You don't want to remove license_file but instead remove license.

@serhii73 serhii73 referenced this issue Dec 31, 2018

Merged

Remove the license argument #159

3 of 15 tasks complete
@serhii73

This comment has been minimized.

Copy link
Contributor

serhii73 commented Dec 31, 2018

I read it https://packaging.python.org/guides/distributing-packages-using-setuptools/#license
And fully understand, I think, why don't need this line(the license argument).

webknjaz added a commit that referenced this issue Dec 31, 2018

🔥 Remove the custom license value from dist meta
Closes #154

Signed-off-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment