New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Client Certificates #108

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@jaraco
Member

jaraco commented Aug 29, 2018

This is a re-submission of #52.


This change is Reviewable

@webknjaz

This comment has been minimized.

Member

webknjaz commented Aug 29, 2018

Why didn't you just push to original branch?

@webknjaz

This comment has been minimized.

Member

webknjaz commented Aug 29, 2018

This needs rebase in order to bypass checks

@jaraco

This comment has been minimized.

Member

jaraco commented Aug 29, 2018

Why didn't you just push to original branch?

I tried, but I didn't have permission.

@jaraco

This comment has been minimized.

Member

jaraco commented Aug 29, 2018

This needs rebase in order to bypass checks

The PR handles this. The commits themselves fail tests, but the PR build performs the merge and runs the tests on that, which are passing (https://travis-ci.org/cherrypy/cheroot/builds/422106587).

from cheroot.ssl.builtin import BuiltinSSLAdapter
from cheroot.test import helper
import cheroot
import ddt

This comment has been minimized.

@jaraco jaraco merged commit cd99041 into master Aug 29, 2018

5 of 11 checks passed

codeclimate 2 issues to fix
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
LGTM analysis: Python Comparing results
Details
ci/circleci: macos-build CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
License Compliance All checks passed.
Details
WIP ready for review
Details
ci/circleci: linux-build Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

jaraco added a commit that referenced this pull request Aug 29, 2018

@jaraco jaraco deleted the pr/52-require-client-certificates branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment