Require setuptools, cheroot/__init__.py imports pkg_resources #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β What kind of change does this PR introduce?
π What is the related issue number (starting with
#
)β What is the current behavior? (You can also link to an open issue here)
pkg_resources needs setuptools as a runtime dependency. Since it wasn't specified so far, there was a possibility of
ModuleNotFoundError: No module named 'pkg_resources'
in case of setuptools not being present. There is a way how to install packages without setuptools or setuptools can be uninstalled after cheroot package was installed. My PR prevents this error.β What is the new behavior (if this is a feature change)?
π Other information:
π Checklist:
and description in grammatically correct, complete sentences
This change isβ