Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Catch known built-in SSL provider errors #4
We (well, our users) have been using CherryPy with the built-in SSL module quite extensively and a number of errors have come up that are thrown by the built-in provider that can just be ignored.
An easy example is running the http://testssl.sh/ script against a CherryPy server that uses the built-in provider with any type of certificates.
Maybe we can add some logging about dropped connections to the access log? I wasn't sure, because nowhere in these modules the logging is used.
referenced this pull request
Feb 14, 2017
I don't really have a comment on whether this is right or not. It seems suitable.
You're right that you can't log to the cherrypy access log, because this package is meant to be agnostic to cherrypy and used by other servers.
Can you add a changelog entry to CHANGES.rst explaining the change?