Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Require client certificates #52
Subject and issuer of the client certificate are passed downstream via WSGI environment. For instance, certificate subject is passed down as SSL_CLIENT_S_DN_* fields.
There will be a forthcoming PR to cherrypy with an
I plan to incorporate the tests from CherryPy cherrypy/cherrypy#1001, but I expect most of them belong in CherryPy. I'm happy to add tests here for these changes, though, if you'd like.
CONTRIBUTING.rst has a note to ensure you set up pre-commit utility correctly and TravisCI tests pass, but it is not clear to me how to do this, and your guidance is appreciated.
@@ Coverage Diff @@ ## master #52 +/- ## ========================================= + Coverage 66.08% 66.7% +0.61% ========================================= Files 15 16 +1 Lines 2748 2850 +102 ========================================= + Hits 1816 1901 +85 - Misses 932 949 +17
@dpeschman Thank you for your contribution!
referenced this pull request
Aug 29, 2018
I see the pre-commit failing with: