Skip to content

Regression in client expectation with Location header #1440

@jaraco

Description

@jaraco

In girder/girder#1362, they report that their test suite begins to fail with CherryPy 5.4.0 due to #1432. I'm thinking we need to revisit that change in light of that report.

When I approved that pull request, I was thinking that the value should have been encoded to bytes in order to fulfill a network request. On a second examination, I see that there are other values in the cherrypy.response.headers that aren't bytes (such as Content-Type, set just above).

I'm inclined now to back out the change, but I want to first give @poofeg a chance to revisit the change and suggest perhaps a better solution.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions