New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in client expectation with Location header #1440

Closed
jaraco opened this Issue Jun 5, 2016 · 1 comment

Comments

2 participants
@jaraco
Member

jaraco commented Jun 5, 2016

In girder/girder#1362, they report that their test suite begins to fail with CherryPy 5.4.0 due to #1432. I'm thinking we need to revisit that change in light of that report.

When I approved that pull request, I was thinking that the value should have been encoded to bytes in order to fulfill a network request. On a second examination, I see that there are other values in the cherrypy.response.headers that aren't bytes (such as Content-Type, set just above).

I'm inclined now to back out the change, but I want to first give @poofeg a chance to revisit the change and suggest perhaps a better solution.

@poofeg

This comment has been minimized.

Show comment
Hide comment
@poofeg

poofeg Jun 5, 2016

Contributor

I think it would be better solution to URL encode (percent-encoding) the redirect URL. It is suitable for all Python versions.

Contributor

poofeg commented Jun 5, 2016

I think it would be better solution to URL encode (percent-encoding) the redirect URL. It is suitable for all Python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment