You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[TODO: remove in v15] Duplicate HTTP Auth Basic and HTTP Auth Digest tools have to be merged #1688
While working on #1680 I realized that there's functional duplication in tools we provide by default.
There's auth_basic, auth_digest and also basic_auth, digest_auth.
They also have duplicate tests spread across 3-5 test modules, which has to be handled as well.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, e.g. stackoverflow, gitter, etc.)
—
changed the title [-]Duplicate HTTP Auth Basic and HTTP Auth Digest tools have to be merged[/-][+][TODO: remove in v15] Duplicate HTTP Auth Basic and HTTP Auth Digest tools have to be merged[/+]on Apr 22, 2018
At YouGov, we have some applications that still use the deprecated handlers. I'm not sure we've given enough time for deprecation warnings to be noticed and addressed.
Also, it's not that we had forgotten to remove it; we just hadn't yet removed it. I don't think there's any prescribed schedule for removing deprecated functionality.
Activity
Deprecate basic_auth and digest_auth tools. Ref #1688.
Deprecate httpauth module. Ref #1688.
remove tests for deprecated modules. Ref #1688
Remove documentation references to deprecated and removed modules. Ref …
Update changelog. Ref #1688.
Revert "remove tests for deprecated modules. Ref #1688"
Remove documentation references to deprecated and removed modules. Ref …
Update changelog. Ref #1688.
[-]Duplicate HTTP Auth Basic and HTTP Auth Digest tools have to be merged[/-][+][TODO: remove in v15] Duplicate HTTP Auth Basic and HTTP Auth Digest tools have to be merged[/+]webknjaz commentedon May 21, 2018
@jaraco we've forgotten to remove this thing. Maybe we need some label for deprecations to check before doing major releases?
webknjaz commentedon May 21, 2018
The only thing I worry about is that new tool runs on
before_handler, while the old one was used to be running onon_start_resource.jaraco commentedon May 21, 2018
At YouGov, we have some applications that still use the deprecated handlers. I'm not sure we've given enough time for deprecation warnings to be noticed and addressed.
Also, it's not that we had forgotten to remove it; we just hadn't yet removed it. I don't think there's any prescribed schedule for removing deprecated functionality.
webknjaz commentedon May 21, 2018
Well, I removed those in master.