New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CherryPy uses _pyio incorrectly #1704

Closed
bangorr opened this Issue Apr 13, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@bangorr

bangorr commented Apr 13, 2018

Attempting to use CherryPy on Cygwin has revealed that CherryPy imports a private module, _pyio. "Outside" use of _pyio this way is not supported.

CherryPy should use a different module or interface for this functionality (https://github.com/cherrypy/cheroot/blob/86c6b246ec7cb704c6f96123556db1a083301634/cheroot/makefile.py#L5).

A side-effect of fixing this issue is that this may help CherryPy run on Cygwin once again.

See https://bugs.python.org/issue32287 for more discussion or context.

@webknjaz

This comment has been minimized.

Member

webknjaz commented Apr 13, 2018

Hello, this ticket should be open under Cheroot repo, so that it won't get lost/out of track.

P.S. It looks like regression, which happens to be caused by this patch:
cherrypy/cheroot@270b0ea#diff-d99a7689c2159eab73db39f9e5b89a1dL5
PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment