New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the filter API #50

Closed
bb-migration opened this Issue Dec 8, 2004 · 3 comments

Comments

Projects
None yet
1 participant
@bb-migration

bb-migration commented Dec 8, 2004

Originally reported by: Anonymous


We need to define the full api for the filters. [[br]]
There are two seperate baseobjects, but there is still '''one''' list.

We wanted to change it if i'm not mistaken into two lists.

  • One for incoming, (BaseInputFilters)
  • and one for outgoing. (BaseOutputFilters)

This would allow for more advanced (but in no case rare) setups.

Futhermore we need to have our api ready to convert all the filters (the longer we wait, the more difficult it will get to change the filters), and to move several other items to filters as well:

  • Sessions (it's an option, i know :) )
  • CSAuthenticate (as this interferes with any generator based templating filter)
  • Caching ?

Moving more features to filters allows the end programmer to have more control, and to decrease the need to patch the server directly. This will make it easier for developers to migrate to CherryPy.

Reported by remco.boerma@gmail.com


@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Dec 8, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


See #38 as well

bb-migration commented Dec 8, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


See #38 as well

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Dec 11, 2004

Original comment by Anonymous:


This is done now.
We still keep only one queue, but we split filters into input filters and output filters.

bb-migration commented Dec 11, 2004

Original comment by Anonymous:


This is done now.
We still keep only one queue, but we split filters into input filters and output filters.

@bb-migration

This comment has been minimized.

Show comment
Hide comment
@bb-migration

bb-migration Dec 12, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


So we've split the filters. But in fact, nothing changes. also not the order in which the output filters are called vs the order in which the inputfilters are called.

I will try to make things more clear, and put them in the experimental using a different implementation

bb-migration commented Dec 12, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


So we've split the filters. But in fact, nothing changes. also not the order in which the output filters are called vs the order in which the inputfilters are called.

I will try to make things more clear, and put them in the experimental using a different implementation

jaraco added a commit that referenced this issue Apr 30, 2016

Merged in shroom/cherrypy (pull request #50)
Fix race condition in session clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment