Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the filter API #50

Closed
ghost opened this issue Dec 8, 2004 · 3 comments
Closed

Define the filter API #50

ghost opened this issue Dec 8, 2004 · 3 comments

Comments

@ghost
Copy link

@ghost ghost commented Dec 8, 2004

Originally reported by: Anonymous


We need to define the full api for the filters. [[br]]
There are two seperate baseobjects, but there is still '''one''' list.

We wanted to change it if i'm not mistaken into two lists.

  • One for incoming, (BaseInputFilters)
  • and one for outgoing. (BaseOutputFilters)

This would allow for more advanced (but in no case rare) setups.

Futhermore we need to have our api ready to convert all the filters (the longer we wait, the more difficult it will get to change the filters), and to move several other items to filters as well:

  • Sessions (it's an option, i know :) )
  • CSAuthenticate (as this interferes with any generator based templating filter)
  • Caching ?

Moving more features to filters allows the end programmer to have more control, and to decrease the need to patch the server directly. This will make it easier for developers to migrate to CherryPy.

Reported by remco.boerma@gmail.com


@ghost
Copy link
Author

@ghost ghost commented Dec 8, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


See #38 as well

@ghost
Copy link
Author

@ghost ghost commented Dec 11, 2004

Original comment by Anonymous:


This is done now.
We still keep only one queue, but we split filters into input filters and output filters.

@ghost
Copy link
Author

@ghost ghost commented Dec 12, 2004

Original comment by Remco Wendt (Bitbucket: remco, GitHub: remco):


So we've split the filters. But in fact, nothing changes. also not the order in which the output filters are called vs the order in which the inputfilters are called.

I will try to make things more clear, and put them in the experimental using a different implementation

@ghost ghost closed this Apr 30, 2016
jaraco added a commit that referenced this issue Apr 30, 2016
Fix race condition in session clean up.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants
You can’t perform that action at this time.