Fix unicode url in HTTPRedirect on Python 3 #1432
Merged
Conversation
If Location header is unicode string, it will be encoded with rules of RFC 2047 later. Browsers do not understand Location header like =?utf-8?b?....
|
This defect probably demands a unit test to capture the failure and prove the fix. |
|
Done. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If Location header is unicode string, it will be encoded with rules of RFC 2047 later. Browsers do not understand Location header like =?utf-8?b?....