New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode url in HTTPRedirect on Python 3 #1432

Merged
merged 3 commits into from May 10, 2016

Conversation

2 participants
@poofeg
Contributor

poofeg commented May 10, 2016

If Location header is unicode string, it will be encoded with rules of RFC 2047 later. Browsers do not understand Location header like =?utf-8?b?....

Fix unicode url in HTTPRedirect on Python 3
If Location header is unicode string, it will be encoded with rules of RFC 2047 later. Browsers do not understand Location header like =?utf-8?b?....
@jaraco

This comment has been minimized.

Member

jaraco commented May 10, 2016

This defect probably demands a unit test to capture the failure and prove the fix.

@poofeg

This comment has been minimized.

Contributor

poofeg commented May 10, 2016

Done.

@jaraco jaraco merged commit ecf7b3d into cherrypy:master May 10, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jaraco

This comment has been minimized.

Member

jaraco commented May 10, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment