Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
|
This defect probably demands a unit test to capture the failure and prove the fix. |
poofeg
added some commits
May 10, 2016
This comment has been minimized.
This comment has been minimized.
|
Done. |
jaraco
merged commit ecf7b3d
into
cherrypy:master
May 10, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
This comment has been minimized.
|
LGTM |
poofeg
deleted the
poofeg:patch-2
branch
May 11, 2016
jaraco
referenced this pull request
Jun 5, 2016
Closed
Regression in client expectation with Location header #1440
added a commit
that referenced
this pull request
Jun 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
poofeg commentedMay 10, 2016
If Location header is unicode string, it will be encoded with rules of RFC 2047 later. Browsers do not understand Location header like =?utf-8?b?....