You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ntob and tonative are deprecated constructs, so probably shouldn't be used here. An the very least, I think the change to _set_id is no better than the implementation that's in place now. Why ensure it's unicode just to convert it to bytes?
I can see the value in the change to _get_id as it provides backward compatibility for older versions of python-memcached on Python 2.
Personally, I'd be inclined to drop support for older versions of python-memcachd, and remove all of this workaround code altogether. What do you think?
Well, I think to do so we need to add dependency restriction.
I suggest adding extras to setup.py.
It would be useful for end-users as well. If they want to use memcached backed sessions they'll just specify (e.g.) cherrypy[memcached-sessions] and won't need to track memcached client version themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1453