Skip to content

Don't chdir when running as a daemon#1547

Merged
jaraco merged 3 commits into
masterfrom
bugfix/daemon-as-a-module
Jan 11, 2017
Merged

Don't chdir when running as a daemon#1547
jaraco merged 3 commits into
masterfrom
bugfix/daemon-as-a-module

Conversation

@webknjaz

@webknjaz webknjaz commented Jan 9, 2017

Copy link
Copy Markdown
Member

Fixes #1546

@jaraco do you know the purpose of that os.chdir('/')?

@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch 3 times, most recently from 5c65ef1 to 7d54519 Compare January 10, 2017 09:36
@webknjaz

Copy link
Copy Markdown
Member Author

@jaraco Do you agree with removing chdir (7d54519)? This is the only question stopping me from merging this PR.

@webknjaz

Copy link
Copy Markdown
Member Author

there's also an option to chdir to _module__file__base instead.

Also:
* remove ``cherrypy/cherryd``
* run cherryd as cherrypy.__main__ module to support Python 2.6
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 7d54519 to 793a578 Compare January 10, 2017 16:39
Also:
* raise RuntimeError when trying to reconstruct `-c`
* run cherryd as cherrypy.__main__ module to support Python 2.6

Ref: #1545
Ref: python/cpython@418baf9
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 793a578 to 9bcf3fb Compare January 11, 2017 11:46
@webknjaz webknjaz requested a review from jaraco January 11, 2017 11:59
@jaraco jaraco merged commit 2ce092b into master Jan 11, 2017
jaraco added a commit that referenced this pull request Jan 13, 2017
@jaraco jaraco deleted the bugfix/daemon-as-a-module branch December 17, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants