Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't chdir when running as a daemon #1547

Merged
merged 3 commits into from Jan 11, 2017
Merged

Don't chdir when running as a daemon #1547

merged 3 commits into from Jan 11, 2017

Conversation

@webknjaz
Copy link
Member

webknjaz commented Jan 9, 2017

Fixes #1546

@jaraco do you know the purpose of that os.chdir('/')?

@jaraco jaraco force-pushed the master branch from e1abe60 to 80f384b Jan 10, 2017
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch 3 times, most recently from 5c65ef1 to 7d54519 Jan 10, 2017
@webknjaz
Copy link
Member Author

webknjaz commented Jan 10, 2017

@jaraco Do you agree with removing chdir (7d54519)? This is the only question stopping me from merging this PR.

@webknjaz
Copy link
Member Author

webknjaz commented Jan 10, 2017

there's also an option to chdir to _module__file__base instead.

Also:
* remove ``cherrypy/cherryd``
* run cherryd as cherrypy.__main__ module to support Python 2.6
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 7d54519 to 793a578 Jan 10, 2017
webknjaz added 2 commits Jan 9, 2017
Also:
* raise RuntimeError when trying to reconstruct `-c`
* run cherryd as cherrypy.__main__ module to support Python 2.6

Ref: #1545
Ref: python/cpython@418baf9
Fixes #1546
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 793a578 to 9bcf3fb Jan 11, 2017
@webknjaz webknjaz requested a review from jaraco Jan 11, 2017
@jaraco jaraco merged commit 2ce092b into master Jan 11, 2017
4 of 5 checks passed
4 of 5 checks passed
codacy/pr Not so good... This pull request quality could be better.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jaraco added a commit that referenced this pull request Jan 13, 2017
jaraco added a commit that referenced this pull request Jan 13, 2017
@jaraco jaraco deleted the bugfix/daemon-as-a-module branch Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.