Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't chdir when running as a daemon #1547

Merged
merged 3 commits into from Jan 11, 2017
Merged

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Jan 9, 2017

Fixes #1546

@jaraco do you know the purpose of that os.chdir('/')?

@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch 3 times, most recently from 5c65ef1 to 7d54519 Compare Jan 10, 2017
@webknjaz
Copy link
Member Author

@jaraco Do you agree with removing chdir (7d54519)? This is the only question stopping me from merging this PR.

@webknjaz
Copy link
Member Author

there's also an option to chdir to _module__file__base instead.

Also:
* remove ``cherrypy/cherryd``
* run cherryd as cherrypy.__main__ module to support Python 2.6
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 7d54519 to 793a578 Compare Jan 10, 2017
webknjaz added 2 commits Jan 11, 2017
Also:
* raise RuntimeError when trying to reconstruct `-c`
* run cherryd as cherrypy.__main__ module to support Python 2.6

Ref: #1545
Ref: python/cpython@418baf9
@webknjaz webknjaz force-pushed the bugfix/daemon-as-a-module branch from 793a578 to 9bcf3fb Compare Jan 11, 2017
@webknjaz webknjaz requested a review from jaraco Jan 11, 2017
@jaraco jaraco merged commit 2ce092b into master Jan 11, 2017
jaraco added a commit that referenced this pull request Jan 13, 2017
@jaraco jaraco deleted the bugfix/daemon-as-a-module branch Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants