Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
codacy-bot
commented
Oct 28, 2017
|
Issues
======
+ Solved 2
- Added 2
See the complete overview on Codacy |
cherrypy/lib/httputil.py
Outdated
| @@ -377,49 +379,16 @@ def parse_query_string(query_string, keep_blank_values=True, encoding='utf-8'): | ||
| return pm | ||
| class CaseInsensitiveDict(dict): | ||
| class CaseInsensitiveDict(jaraco.collections.KeyTransformingDict): |
This comment has been minimized.
This comment has been minimized.
cherrypy/lib/httputil.py
Outdated
| def pop(self, key, default): | ||
| return dict.pop(self, str(key).title(), default) | ||
| @staticmethod | ||
| def transform_key(key): |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
webknjaz
Oct 29, 2017
Member
I think, we could invent better name: this one doesn't give an idea of what's going on here.
This comment has been minimized.
This comment has been minimized.
jaraco
referenced this pull request
Dec 17, 2017
Merged
Internalize jaraco.classes code to replace dependency #1671
jaraco
reviewed
Dec 17, 2017
In light of #1671, this dependency is not allowed, so the functionality must be inlined before this PR can move forward in the current master.
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Dec 17, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=========================================
+ Coverage 78.04% 78.9% +0.86%
=========================================
Files 106 106
Lines 13798 15761 +1963
=========================================
+ Hits 10769 12437 +1668
- Misses 3029 3324 +295 |
jaraco
force-pushed the
feature/reuse-case-insensitive-dict
branch
from
08c1e5f
to
5da63b7
Dec 17, 2017
jaraco
referenced this pull request
Dec 17, 2017
Closed
init method added to CaseInsensitiveDict #1633
jaraco
force-pushed the
feature/reuse-case-insensitive-dict
branch
from
5da63b7
to
3bcefda
Dec 17, 2017
jaraco
added some commits
Dec 17, 2017
jaraco
merged commit 0e45422
into
master
Dec 17, 2017
1 of 7 checks passed
ci/circleci
CircleCI is running your tests
Details
continuous-integration/appveyor/branch
Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr
Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
continuous-integration/travis-ci/push
The Travis CI build is in progress
Details
lgtm analysis: Python
Running analyses for revisions
Details
WIP
ready for review
Details
jaraco
deleted the
feature/reuse-case-insensitive-dict
branch
Dec 17, 2017
This comment has been minimized.
This comment has been minimized.
|
This pull request fixes 1 alert - view on lgtm.com fixed alerts:
Comment posted by lgtm.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jaraco commentedOct 28, 2017
Feature and Bugfix and code removal.
#)#1231
CherryPy has its own limited implementation of a Case-Insensitive Dict.
I was reviewing #1633, I realized I'd seen this pattern before... and built a general-purpose class for its purpose... and released it as a library for others to consume. This approach removes CherryPy's bespoke implementation, which has the reported deficiency, and replaces it with the proven class found in jaraco.collections.