Use jaraco.collections for code re-use on CaseInsensitiveDict. #1654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
=========================================
+ Coverage 78.04% 78.9% +0.86%
=========================================
Files 106 106
Lines 13798 15761 +1963
=========================================
+ Hits 10769 12437 +1668
- Misses 3029 3324 +295 |
08c1e5f
to
5da63b7
5da63b7
to
3bcefda
This pull request fixes 1 alert - view on lgtm.com fixed alerts:
Comment posted by lgtm.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Feature and Bugfix and code removal.
#
)#1231
CherryPy has its own limited implementation of a Case-Insensitive Dict.
I was reviewing #1633, I realized I'd seen this pattern before... and built a general-purpose class for its purpose... and released it as a library for others to consume. This approach removes CherryPy's bespoke implementation, which has the reported deficiency, and replaces it with the proven class found in jaraco.collections.