New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single subscribe method for decorator or direct invocation #1656

Merged
merged 3 commits into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@jaraco
Member

jaraco commented Oct 29, 2017

This approach presents an alternative approach to afb5b33, in which only one subscribe method is presented and the decorator functionality is exposed when no callback is supplied.

Thoughts?

Alternatively, engine.subscribe now allows calling without a callback…
…, in which case it creates the decorator.

jaraco referenced this pull request Oct 29, 2017

@webknjaz

This comment has been minimized.

Member

webknjaz commented Oct 29, 2017

E   TypeError: subscribe() got multiple values for keyword argument 'channel'
@jaraco

This comment has been minimized.

Member

jaraco commented Oct 29, 2017

Ugh. Did I really do that?

I tested the code, then reformatted it, then committed and pushed and made a PR. ...but I added a regression in the reformatting, now corrected.

@webknjaz

This comment has been minimized.

Member

webknjaz commented Oct 30, 2017

@codecov

This comment has been minimized.

codecov bot commented Nov 6, 2017

Codecov Report

Merging #1656 into master will increase coverage by 0.89%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   76.98%   77.87%   +0.89%     
==========================================
  Files         106      106              
  Lines       14372    15171     +799     
==========================================
+ Hits        11064    11815     +751     
- Misses       3308     3356      +48

@jaraco jaraco merged commit 3b239d3 into master Nov 10, 2017

9 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch 90% of diff hit (target 76.98%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details

jaraco added a commit that referenced this pull request Nov 14, 2017

@jaraco jaraco deleted the feature/single-subscribe branch Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment