Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single subscribe method for decorator or direct invocation #1656

merged 3 commits into from Nov 10, 2017


Copy link

@jaraco jaraco commented Oct 29, 2017

This approach presents an alternative approach to afb5b33, in which only one subscribe method is presented and the decorator functionality is exposed when no callback is supplied.


jaraco referenced this pull request Oct 29, 2017
Copy link

E   TypeError: subscribe() got multiple values for keyword argument 'channel'

Copy link
Member Author

jaraco commented Oct 29, 2017

Ugh. Did I really do that?

I tested the code, then reformatted it, then committed and pushed and made a PR. ...but I added a regression in the reformatting, now corrected.

Copy link

@jaraco try re-running and feel free to merge this PR

Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #1656 into master will increase coverage by 0.89%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
+ Coverage   76.98%   77.87%   +0.89%     
  Files         106      106              
  Lines       14372    15171     +799     
+ Hits        11064    11815     +751     
- Misses       3308     3356      +48

@jaraco jaraco merged commit 3b239d3 into master Nov 10, 2017
jaraco added a commit that referenced this pull request Nov 14, 2017
@jaraco jaraco deleted the feature/single-subscribe branch December 17, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants