Use single subscribe method for decorator or direct invocation #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, in which case it creates the decorator.
E TypeError: subscribe() got multiple values for keyword argument 'channel' |
|
Ugh. Did I really do that? I tested the code, then reformatted it, then committed and pushed and made a PR. ...but I added a regression in the reformatting, now corrected. |
webknjaz
approved these changes
Oct 30, 2017
|
@jaraco try re-running https://ci.appveyor.com/project/jaraco/cherrypy/build/1.0.459/job/cls4x77usuklwess and feel free to merge this PR |
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
+ Coverage 76.98% 77.87% +0.89%
==========================================
Files 106 106
Lines 14372 15171 +799
==========================================
+ Hits 11064 11815 +751
- Misses 3308 3356 +48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach presents an alternative approach to afb5b33, in which only one subscribe method is presented and the decorator functionality is exposed when no callback is supplied.
Thoughts?