Skip to content

Deprecate old auth tools - #1689

Merged
jaraco merged 5 commits into
masterfrom
feature/deprecate-old-auth
Feb 4, 2018
Merged

Deprecate old auth tools#1689
jaraco merged 5 commits into
masterfrom
feature/deprecate-old-auth

Conversation

@jaraco

@jaraco jaraco commented Jan 13, 2018

Copy link
Copy Markdown
Member

This change is the first of two phases for #1688.

@jaraco
jaraco requested a review from webknjaz January 13, 2018 15:13
@codecov

codecov Bot commented Jan 13, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1689 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
- Coverage   78.18%   78.09%   -0.09%     
==========================================
  Files         106      106              
  Lines       13807    13847      +40     
==========================================
+ Hits        10795    10814      +19     
- Misses       3012     3033      +21

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz don't remove tests as this will conflict with #1683. We need to move tests to valid implementation.

@jaraco

jaraco commented Jan 13, 2018

Copy link
Copy Markdown
Member Author

conflict with #1683

Perhaps #1683 should disregard the deprecated modules?

We need to move tests to valid implementation.

Is that true? Or can we simply ignore them? If someone wishes to port/implement those tests for the new, preferred tools, I welcome that, but I'd consider that outside the scope of this effort.

@webknjaz

Copy link
Copy Markdown
Member

This pull request fixes 1 alert - view on lgtm.com

fixed alerts:

  • 1 for Potentially uninitialized local variable

Comment posted by lgtm.com

@jaraco
jaraco force-pushed the feature/deprecate-old-auth branch from 3134dec to 8e7c6c2 Compare February 4, 2018 17:28
@jaraco

jaraco commented Feb 4, 2018

Copy link
Copy Markdown
Member Author

I've removed the commit that removed the tests.

@jaraco
jaraco merged commit 15ba399 into master Feb 4, 2018
@jaraco
jaraco deleted the feature/deprecate-old-auth branch February 4, 2018 17:29
@webknjaz

webknjaz commented Feb 4, 2018

Copy link
Copy Markdown
Member

Actually, there's DeprecationTool in _cptools. And it looks like a right place for adding deprecation

@jaraco

jaraco commented Feb 4, 2018

Copy link
Copy Markdown
Member Author

Hmm. I honestly don't understand how DeprecatedTool is meant to work. In the two places it's used, it's not wrapping another tool, but merely acting as a stand-in for another tool that was removed. I think we should remove the DeprecatedTool also, because its name betrays its purpose (it's not deprecating if it's replacing) and because there's no useful example of using it to deprecate a tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants