New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old auth tools #1689

Merged
merged 5 commits into from Feb 4, 2018

Conversation

Projects
None yet
3 participants
@jaraco
Member

jaraco commented Jan 13, 2018

This change is the first of two phases for #1688.

@jaraco jaraco requested a review from webknjaz Jan 13, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 13, 2018

Codecov Report

Merging #1689 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
- Coverage   78.18%   78.09%   -0.09%     
==========================================
  Files         106      106              
  Lines       13807    13847      +40     
==========================================
+ Hits        10795    10814      +19     
- Misses       3012     3033      +21
@webknjaz

Plz don't remove tests as this will conflict with #1683. We need to move tests to valid implementation.

@jaraco

This comment has been minimized.

Member

jaraco commented Jan 13, 2018

conflict with #1683

Perhaps #1683 should disregard the deprecated modules?

We need to move tests to valid implementation.

Is that true? Or can we simply ignore them? If someone wishes to port/implement those tests for the new, preferred tools, I welcome that, but I'd consider that outside the scope of this effort.

@webknjaz

This comment has been minimized.

Member

webknjaz commented Jan 13, 2018

This pull request fixes 1 alert - view on lgtm.com

fixed alerts:

  • 1 for Potentially uninitialized local variable

Comment posted by lgtm.com

@codacy-bot

This comment has been minimized.

codacy-bot commented Jan 14, 2018

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

# import late to avoid deprecation warning on import
httpauth = None

This comment has been minimized.

@jaraco jaraco force-pushed the feature/deprecate-old-auth branch from 3134dec to 8e7c6c2 Feb 4, 2018

@jaraco

This comment has been minimized.

Member

jaraco commented Feb 4, 2018

I've removed the commit that removed the tests.

@jaraco jaraco merged commit 15ba399 into master Feb 4, 2018

1 of 7 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
lgtm analysis: Python Running analyses for revisions
Details
WIP ready for review
Details

@jaraco jaraco deleted the feature/deprecate-old-auth branch Feb 4, 2018

@webknjaz

This comment has been minimized.

Member

webknjaz commented Feb 4, 2018

Actually, there's DeprecationTool in _cptools. And it looks like a right place for adding deprecation

@jaraco

This comment has been minimized.

Member

jaraco commented Feb 4, 2018

Hmm. I honestly don't understand how DeprecatedTool is meant to work. In the two places it's used, it's not wrapping another tool, but merely acting as a stand-in for another tool that was removed. I think we should remove the DeprecatedTool also, because its name betrays its purpose (it's not deprecating if it's replacing) and because there's no useful example of using it to deprecate a tool.

jaraco added a commit that referenced this pull request Feb 4, 2018

jaraco added a commit that referenced this pull request Feb 4, 2018

jaraco added a commit that referenced this pull request Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment