Fix URI decoding for auth_digest #1717
I'm really grateful that you spend efforts trying to figure this out and help us. We are short on maintainers and are really lucky to have such people like you contributing to the project and making it better!
This change, however, doesn't fix a regression, it monkey-patches what's related/unique to your concrete application, not CherryPy. And it patches the wrong place meaning that something in someone else's workflow gets broken. It's dangerous/harmful to throw in patches like this (even with no tests covering this case), this will likely cause another regression, which would be much harder to identify and eliminte.
As maintainers, @jaraco and I are responsible for the changes we accept and we do our best to avoid mistakes, which might be hard to fix in future. We have to weight every decision we make to ensure we don't introduce sudden regressions, don't break pre-decided design considerations, keep the code base in a good shape.
I hope that this issue gets fixed soon and as a quick workaround for your app I may suggest you to copy-paste this tool into your app, do whatever temporary patches necessary and use it instead of a built-in tool and then switch back to native tool once the fix is released.
Have a nice day and again thank you for your contributions!
@@ Coverage Diff @@ ## master #1717 +/- ## ========================================== - Coverage 80.81% 79.45% -1.36% ========================================== Files 105 105 Lines 13566 13563 -3 ========================================== - Hits 10963 10777 -186 - Misses 2603 2786 +183
There was a problem hiding this comment.