Don't convert bytes headers to str #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair enough. Can we have a test for that, please? |
|
Also, AppVeyor tests failed. |
Don't convert bytes header values using str() as str(b'foo') becomes "b'foo'". Instead just leave bytes as is like it was prior to v18.0.0.
tobiashenkel
force-pushed
the
fix-encoding
branch
from
75e4cd2
to
802d020
Compare
Codecov Report
@@ Coverage Diff @@
## master #1736 +/- ##
==========================================
- Coverage 79.86% 79.84% -0.03%
==========================================
Files 104 104
Lines 13337 13334 -3
==========================================
- Hits 10652 10646 -6
- Misses 2685 2688 +3 |
|
Sure, I added a test case that fails without the fix. |
|
The AppVeyor test seems to fail due to some unrelated installation problem. |
openstack-gerrit
pushed a commit
to openstack-infra/zuul
that referenced
this pull request
Sep 4, 2018
With the latest cherrypy version the tests run into the hard test timeout. This is caused by a header conversion issue introduced in cherrypy 18.0.0. There is a pull request [1] that fixes this issue. Once this is merged and released we can uncap it again. The newest reno release, 2.10.0, requires a feature of newer sphinx without specifying that the minimum compatibility has changed. Uncap sphinx here so at least the doc build is not broken, use Sphinx 1.6.1 since that is the oldest sphinx version supporting what reno needs. [1] cherrypy/cherrypy#1736 Change-Id: Ic00e664152062d1fc1677e467b638ac2be99aef1 Co-Authored-By: Andreas Jaeger <jaegerandi@gmail.com>
2 tasks
webknjaz
added
the
regression
|
This fix is going out as 18.0.1. |
openstack-gerrit
pushed a commit
to openstack-infra/zuul
that referenced
this pull request
Sep 27, 2018
18.0.1 has been released an fixes: cherrypy/cherrypy#1736 Change-Id: Iffda4376e1393020d54ba6e25d0dda07616d72c6 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
h3llrais3r
added a commit
to h3llrais3r/cherrypy
that referenced
this pull request
Nov 4, 2018
Backport cherrypy#1736 Also fixes Lawouach/WebSocket-for-Python#252
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Don't convert bytes header values using str() as str(b'foo') becomes
"b'foo'". Instead just leave bytes as is like it was prior to v18.0.0.