Don't convert bytes headers to str#1755
Merged
Merged
Conversation
Backport cherrypy#1736 Also fixes Lawouach/WebSocket-for-Python#252
Member
|
Hey @h3llrais3r could you please fix tests? |
Contributor
Author
|
@webknjaz Can you check again? |
Codecov Report
@@ Coverage Diff @@
## maint/17.x #1755 +/- ##
==============================================
- Coverage 80.91% 78.94% -1.98%
==============================================
Files 104 104
Lines 13486 13491 +5
==============================================
- Hits 10912 10650 -262
- Misses 2574 2841 +267 |
webknjaz
reviewed
Nov 7, 2018
webknjaz
reviewed
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1736
Also fixes Lawouach/WebSocket-for-Python#252
What kind of change does this PR introduce?