New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't convert bytes headers to str #1755

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@h3llrais3r
Contributor

h3llrais3r commented Nov 4, 2018

Backport #1736
Also fixes Lawouach/WebSocket-for-Python#252

What kind of change does this PR introduce?

  • bug fix
@webknjaz

This comment has been minimized.

Member

webknjaz commented Nov 4, 2018

Hey @h3llrais3r could you please fix tests?

@webknjaz webknjaz requested a review from jaraco Nov 4, 2018

@h3llrais3r

This comment has been minimized.

Contributor

h3llrais3r commented Nov 5, 2018

@webknjaz Can you check again?
I've fixed the travis build (flake8 error) but still errors for pydocstyle (not related to my changes) and tests against latest Python nightly.
As far as I can see, the AppVeyor tests are working fine for Python 2.7, Python 3.5 and Python 3.6. Python 3.5 is not working, but that's not related to my changes...

@codecov

This comment has been minimized.

codecov bot commented Nov 5, 2018

Codecov Report

Merging #1755 into maint/17.x will decrease coverage by 1.97%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           maint/17.x    #1755      +/-   ##
==============================================
- Coverage       80.91%   78.94%   -1.98%     
==============================================
  Files             104      104              
  Lines           13486    13491       +5     
==============================================
- Hits            10912    10650     -262     
- Misses           2574     2841     +267

@webknjaz webknjaz requested review from jaraco and removed request for jaraco Nov 7, 2018

@jaraco jaraco merged commit 4ca9959 into cherrypy:maint/17.x Nov 23, 2018

1 of 4 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
LGTM analysis: Python No alert changes
Details

@h3llrais3r h3llrais3r deleted the h3llrais3r:byte-headers branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment