Reduced log level for non-error events in win32.py#1769
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
- Coverage 80.29% 80.26% -0.03%
==========================================
Files 104 104
Lines 13642 13639 -3
==========================================
- Hits 10954 10948 -6
- Misses 2688 2691 +3 |
Contributor
Author
|
Hi, any update on this? Is there any additional work/discussion required? |
Member
|
I've restarted tests, will merge after success |
Contributor
Author
|
I scanned the failed builds, and I don't see anything that links the failed tests to this code change. I could be wrong though, happy to fix up someone points me in the general direction. |
Member
|
Yeah, TravisCI build got fixed upon restart |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the related issue number (starting with
#)N/A
What is the current behavior? (You can also link to an open issue here)
In win32.py's ConsoleCtrlHandler, if start/stop is called multiple times, this is logged at the ERROR (40) level.
What is the new behavior (if this is a feature change)?
If start/stop is called multiple times, this is logged at the INFO (20) level.
Other information:
Since the code handles the situation well, and there are no side effects to multiple calls, we shouldn't pollute the logs with error level entries.
Also, because ConsoleCtrlHandler is extremely proactive at removing itself (when it captures Ctrl+C or equivalent), even before it attempts to stop the bus, it sometimes ends up that the handler's stop is called multiple times (directly, then via a 'stop' publish event) during normal operations. There's no inherent badness to this, so while it should be noted/logged, it should be logged at a much lower level.
Checklist:
and description in grammatically correct, complete sentences