Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Fix native WSGI-less HTTP server support under Python 3 #1786

merged 3 commits into from Jun 23, 2019


1 participant
Copy link

commented Jun 23, 2019

This is a backport of #1785.

What kind of change does this PR introduce?

  • backport
  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)


What is the current behavior? (You can also link to an open issue here)

It's broken under Python 3

What is the new behavior (if this is a feature change)?

It works under Python 3

Other information:

See #1377


  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@webknjaz webknjaz requested a review from jaraco Jun 23, 2019

@webknjaz webknjaz self-assigned this Jun 23, 2019

webknjaz added some commits Jun 22, 2019

@webknjaz webknjaz force-pushed the backport/17.x--bugfix--native-http-server-py3 branch from 2a1e930 to 05dfecc Jun 23, 2019


This comment has been minimized.

Copy link

commented Jun 23, 2019

Codecov Report

Merging #1786 into maint/17.x will decrease coverage by 3.19%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           maint/17.x    #1786     +/-   ##
- Coverage       81.43%   78.24%   -3.2%     
  Files             104      104             
  Lines           13896    13499    -397     
- Hits            11316    10562    -754     
- Misses           2580     2937    +357

@webknjaz webknjaz merged commit 05dfecc into maint/17.x Jun 23, 2019

2 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
continuous-integration/travis-ci/push The Travis CI build failed
test-linux-and-macos Workflow: test-linux-and-macos
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
LGTM analysis: JavaScript No code changes detected
LGTM analysis: Python No new or fixed alerts
Details No dependencies with known security vulnerabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.