Skip to content

[backport] Fix native WSGI-less HTTP server support under Python 3#1786

Merged
webknjaz merged 3 commits into
maint/17.xfrom
backport/17.x--bugfix--native-http-server-py3
Jun 23, 2019
Merged

[backport] Fix native WSGI-less HTTP server support under Python 3#1786
webknjaz merged 3 commits into
maint/17.xfrom
backport/17.x--bugfix--native-http-server-py3

Conversation

@webknjaz

Copy link
Copy Markdown
Member

This is a backport of #1785.

What kind of change does this PR introduce?

  • backport
  • bug fix
  • feature
  • docs update
  • tests/coverage improvement
  • refactoring
  • other

What is the related issue number (starting with #)

#1377/#1712/#1784/#1785

What is the current behavior? (You can also link to an open issue here)

It's broken under Python 3

What is the new behavior (if this is a feature change)?

It works under Python 3

Other information:

See #1377

Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@webknjaz webknjaz added bug major CherryPy code backport This change is ported to a previous version from the master branch labels Jun 23, 2019
@webknjaz webknjaz requested a review from jaraco June 23, 2019 14:25
@webknjaz webknjaz self-assigned this Jun 23, 2019
@webknjaz webknjaz force-pushed the backport/17.x--bugfix--native-http-server-py3 branch from 2a1e930 to 05dfecc Compare June 23, 2019 14:27
@codecov

codecov Bot commented Jun 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1786 into maint/17.x will decrease coverage by 3.19%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           maint/17.x    #1786     +/-   ##
=============================================
- Coverage       81.43%   78.24%   -3.2%     
=============================================
  Files             104      104             
  Lines           13896    13499    -397     
=============================================
- Hits            11316    10562    -754     
- Misses           2580     2937    +357

@webknjaz webknjaz merged commit 05dfecc into maint/17.x Jun 23, 2019
@webknjaz webknjaz deleted the backport/17.x--bugfix--native-http-server-py3 branch April 29, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This change is ported to a previous version from the master branch bug CherryPy code major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant