Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Support 308 Permanent Redirect HTTP redirect #1794
What kind of change does this PR introduce?
What is the related issue number (starting with
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
@@ Coverage Diff @@ ## master #1794 +/- ## ========================================== - Coverage 80.67% 80.55% -0.12% ========================================== Files 104 104 Lines 13252 13255 +3 ========================================== - Hits 10691 10678 -13 - Misses 2561 2577 +16
Thank @webknjaz Regarding default_status, for what I found 308 is either implemented properly in browsers / clients or not at all. I wouldn't add 308 to the default_redirect. If 308 is not implemented the client should fall back on their unknown status procedure and just render the message.
Apparently, the status text is
I've also checked the client behavior and found out that there's no user confirmation on the browser side so I've corrected that too.