Add tags_before_type_cast method #7

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

tmaier commented Feb 18, 2012

I added a type_before_type_cast method.

basically it does the same as https://gist.github.com/1172956 but by providing a type_before_type_cast method which is then used by Rails FormHelper.

This way it is independent of SimpleForm and has no negative side effects on the generated HTML.

tmaier commented Feb 18, 2012

I have to admit, I'm not sure if this is the best way to do this, especially because of ActiveSupport::Concern.

But as stackexchange is down at the moment, I don't know it any better (Yes, I love to blame someone else)

Owner

ches commented Feb 19, 2012

That looks reasonable -- could you add a test case and update the usage info in the README?

tmaier commented Feb 20, 2012

Added spec for

  • the default case
  • with a different separator
  • with another field name for tags

tmaier commented Jul 6, 2012

Hey @ches,

I just wanted to know if you could merge this pull request or if you need any further work from my side on this?

Owner

ches commented Jul 16, 2012

Sorry for losing track of this, thanks for the reminder -- it looks good, I'll try to get it merged after wrapping up client work today. Might take this opportunity to add Travis CI to the project 😄

Owner

ches commented Jul 17, 2012

Merged, thank you!

ches closed this Jul 17, 2012

tmaier commented Jul 17, 2012

Thank you @ches!

Great to see travis support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment