Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Allow to download screenshots of Capablanca games #27

Closed
programarivm opened this issue Nov 27, 2022 · 0 comments · Fixed by #28
Closed

Allow to download screenshots of Capablanca games #27

programarivm opened this issue Nov 27, 2022 · 0 comments · Fixed by #28
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@programarivm
Copy link
Member

At this moment, src/Controller/DownloadImageController.php doesn't allow to download screenshots of Capablanca chess games as shown in the animation below.

output

However, the /download_image endpoint should accept a new parameter called variant, this way a new $board object can be created accordingly to be then passed to Chess\Player\PgnPlayer.

For further information on how a $board is initialized please visit:

This issue is quite similar to the following one which has been solved already:

Remember:

There is an easy quick way to get the API up and running without an SSL certificate for when testing endpoints that don't require a database connection, e.g., api/download_image or api/download_mp4. In such cases you may want to use PHP's built-in web server.

Keep it up, and happy coding and learning!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant